GANTASMO masthead and footer, correct attribution, gallery re-rendere… - #4
Merged
Conversation
…d on the app's backend The README opens the way theDAW's does: the banner, a stack and identity badge block, the GANTASMO links, and the identity paragraph, then the project. The same links close the file over "Made by Daniel Joaquin Trujillo and Josh Valenzuela as GANTASMO." The badges are Markdown rather than the centred HTML theDAW uses, because the in-app documentation viewer escapes HTML; there they degrade to plain text links instead of escaped markup. Project and stack badges carry the cockpit's cyan and magenta, the social row keeps the platform brand colours. Attribution corrected throughout. LICENSE and the Legal section now read "Daniel Joaquin Trujillo and GANTASMO". The masthead cites nine external hosts, and the documented invariant is that EXTERNAL_ALLOW covers every host the bundled documentation cites, so gantasmo.com, spotify.com, youtube.com, instagram.com, x.com, electronjs.org and threejs.org join the list, with the ARCHITECTURE and OVERVIEW enumerations updated to match. The gallery is re-rendered, and the note that shipped with it was wrong. The first run measured 135 s and 103 s first draws for naturestomb and miraclemile and called that the open compile regression; it is not. The harness does not inherit the application's Electron switches, so those numbers were ANGLE's D3D11 path, which commit 4f12098 already moved the app off. gallery.plan.json now sets electronArgs to the same --use-angle=gl and --gpu-program-cache-size-kb=524288 that main.js sets, every still is re-rendered on that backend, and the same two scenes first-draw in 5.2 s and 3.7 s.
There was a problem hiding this comment.
🟡 Changes recommended
Some bundled documentation links remain blocked and the allowlist documentation is inconsistent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates GANTASMO branding and attribution while aligning gallery rendering with the application’s GPU backend.
Changes:
- Adds branded masthead/footer and corrects attribution.
- Expands the external-link allowlist and documentation.
- Configures gallery rendering to use OpenGL and the larger shader cache.
File summaries
| File | Description |
|---|---|
src/main/main.js |
Expands allowed external domains. |
README.md |
Adds branding, badges, links, and attribution. |
LICENSE |
Updates copyright ownership. |
docs/OVERVIEW.md |
Documents the expanded allowlist. |
docs/ARCHITECTURE.md |
Adds new domains to the policy table. |
docs/media/README.md |
Documents corrected rendering benchmarks. |
docs/media/gallery.plan.json |
Adds Electron GPU arguments and reformats shots. |
Review details
Suppressed comments (1)
README.md:28
- The phrase is missing “of”: it should read “in the fields of Artificial Intelligence.”
> Artificial Intelligence, Augmented Reality, Virtual Reality, the democratization of
- Files reviewed: 7/25 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 'instagram.com', | ||
| 'x.com', | ||
| 'electronjs.org', | ||
| 'threejs.org', |
| [](https://audima.com.au) | ||
|  | ||
| [](https://github.com/gantasmo/theDAW) | ||
| [](LICENSE) |
Comment on lines
+156
to
+160
| | `gantasmo.com` | | ||
| | `spotify.com` | | ||
| | `youtube.com` | | ||
| | `instagram.com` | | ||
| | `x.com` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d on the app's backend
The README opens the way theDAW's does: the banner, a stack and identity badge block, the GANTASMO links, and the identity paragraph, then the project. The same links close the file over "Made by Daniel Joaquin Trujillo and Josh Valenzuela as GANTASMO." The badges are Markdown rather than the centred HTML theDAW uses, because the in-app documentation viewer escapes HTML; there they degrade to plain text links instead of escaped markup. Project and stack badges carry the cockpit's cyan and magenta, the social row keeps the platform brand colours.
Attribution corrected throughout. LICENSE and the Legal section now read "Daniel Joaquin Trujillo and GANTASMO".
The masthead cites nine external hosts, and the documented invariant is that EXTERNAL_ALLOW covers every host the bundled documentation cites, so gantasmo.com, spotify.com, youtube.com, instagram.com, x.com, electronjs.org and threejs.org join the list, with the ARCHITECTURE and OVERVIEW enumerations updated to match.
The gallery is re-rendered, and the note that shipped with it was wrong. The first run measured 135 s and 103 s first draws for naturestomb and miraclemile and called that the open compile regression; it is not. The harness does not inherit the application's Electron switches, so those numbers were ANGLE's D3D11 path, which commit 4f12098 already moved the app off. gallery.plan.json now sets electronArgs to the same --use-angle=gl and --gpu-program-cache-size-kb=524288 that main.js sets, every still is re-rendered on that backend, and the same two scenes first-draw in 5.2 s and 3.7 s.